Fix 17786 - CompileBefore/CompileAfter is lost due to the FSharpSourceCodeCompileOrder target #17791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auduchinok let me know if this works for you. |
|
KevinRansom
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Sep 25, 2024
auduchinok
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
@KevinRansom Wow, this is such a simple fix! Looks great, thank you very much! 🙂
|
|
||
| <CompileLast> | ||
| <CompileOrder>CompileLast</CompileOrder> | ||
| </CompileLast> |
There was a problem hiding this comment.
Could you please also add CompileFirst?
I see its usage in FSharpSourceCodeCompileOrder here:
and in FSharp.Core here:
fsharp/src/FSharp.Core/FSharp.Core.fsproj
Line 80 in 6cdcc3c
There was a problem hiding this comment.
@KevinRansom This hasn't been resolved. 😞
esbenbjerre
pushed a commit
to esbenbjerre/fsharp
that referenced
this pull request
Sep 30, 2024
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Oct 4, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17786 - CompileBefore/CompileAfter is lost due to the FSharpSourceCodeCompileOrder target
This adds the CompilationOrder metadata as default metadata to CompileBefore/CompileAfter and CompileLast. This ensures that when they are inserted into the Compile/Sources collection the metadata goes with them.
Currently:
With this change:
